Does what it's meant to do
I wasn't sure if I should go with a large or medium, but went with medium. I wear 32-33 inch pants and the medium is a perfect fit. I think the large size would have been too big.
My only gripe with the product is that putting the cup in when wearing the shorts is a bit of a challenge. The bottom tip of the cup likes to catch the liner in the shorts. I stick my hole hand down in the cup pocket when inserting it, and this makes it easier.